Conversation
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
SummaryThis ports NVIDIA's Cosmos Predict (Cosmos 2.5) T2V/I2V model into FastVideo: a new VAE ( Nice groundwork on the component-level parity tests (VAE/text-encoder/transformer), but I don't think this is mergeable as-is — I found three bugs that mean the pipeline can't have been run end-to-end yet (and the PR's own 🔴 Blocking issues1.
|
…wnsampling, and tests
…, and enhance smoke test
Thanks for the detailed review @Satyam-53 , could you please have a look now, I have addressed your comments |
Purpose
This PR introduces full support for NVIDIA Cosmos Predict 2.5 (2B & 14B) staged video generation pipeline in
FastVideo. It includes model component dispatch, text encoding, spatial/temporal VAE decoding, UniPC noise prediction ladder, local pipeline unit tests, and Slurm verification scripts.Key Architectural & Implementation Changes
Pipeline & Stages (
fastvideo/pipelines/basic/cosmos_predict/):CosmosPredictPipelinebuilt onComposedPipelineBase.CosmosPredictDenoisingStageimplementing the 35-step UniPCMultistep noise prediction ladder with classifier-free guidance (CFG).DecodingStageby adjusting VAE latent un-normalization logic tolatents / latents_std + latents_meanfor Cosmos Predict family models.Model Architecture & Component Loading (
fastvideo/models/):Cosmos2_5DiT transformer loader incomponent_loader.pyandfsdp_load.py.cond_indicator,cond_mask) for frame prediction conditioning.Slurm & Test Verification (
scripts/,tests/local_tests/):run_cosmos_ssim_slurm.shandrun_cosmos_debug_slurm.shexecution scripts.test_cosmos_predict_pipeline_smoke.pyandtest_cosmos_predict_pipeline_parity.pycoverage.Verification & Test Evidence
nvidia/Cosmos-Predict2.5-14B).generated_cosmos_video.mp4(241 KB, 512×512, 25 frames, uint8 RGB)A serene mountain landscape at sunrisegenerated_cosmos_video.mp4
cosmos_coral_reef.mp4(385 KB, 512×512, 25 frames, uint8 RGB)An underwater coral reef teeming with colorful tropical fishcosmos_coral_reef.mp4
pytest tests/local_tests/pipelines/test_cosmos_predict_pipeline_smoke.py: PassedTest Plan
# Commands you ranTest Results
Sample Video Outputs
cosmos_coral_reef.mp4(Generated via Slurm Job 143)cosmos_coral_reef.mp4
generated_cosmos_video.mp4(Generated via Slurm Job 141)generated_cosmos_video.mp4
Test output
Checklist
pre-commit run --all-filesand fixed all issuesFor model/pipeline changes, also check: