fix: correct 14.112-14.150 MHz to CW-only for ITU Region 2#8
Open
chrisdebian wants to merge 1 commit into
Open
fix: correct 14.112-14.150 MHz to CW-only for ITU Region 2#8chrisdebian wants to merge 1 commit into
chrisdebian wants to merge 1 commit into
Conversation
The 20m Phone segment (14112-14350 kHz) was tagged for both Region 1 and Region 2, but Region 2 (Americas) band plans restrict phone to 14150 kHz and above; 14112-14150 is CW-only there. Region 1 correctly allows phone from 14112. Split the segment into a Region-1-only entry (unchanged range) and a new Region-2-only entry starting at 14150, mirroring the existing US-specific override. Updated the test that was asserting the old (incorrect) behavior. Reported on the forum: a Region 2 station at 14.115 MHz was getting SSB instead of CW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 20m Phone segment (14112-14350 kHz) was tagged
"regions": [1, 2], but Region 2 (Americas) band plans restrict phone to 14150 kHz and above — 14112-14150 is CW-only in Region 2. Region 1 correctly allows phone from 14112.This meant
modeForFrequencyreturnedSSBfor a Region 2 station at, e.g., 14.115 MHz, when it should returnCW.Fix
Split the single
regions: [1, 2]Phone entry into:Updated the one test that was asserting the old (incorrect) behavior —
modeForFrequency(14140, { ituRegion: 2 })now expectsCWinstead ofSSB.Context
Raised on the forum by a Region 2 user: https://forums.ham2k.com/t/automatically-defaults-to-wrong-mode-on-14-115/1607 — KI2D confirmed a PR would be welcome.
Test plan
npx jest— all 4 existing tests pass, including the corrected onenpx tsc --noEmit— cleanmodeForFrequency(14115, { ituRegion: 2 })against the updated data and confirmed it now resolves toCW