Trigger halide/Halide's upgrade-llvm workflow after publishing - #8
Open
alexreinking wants to merge 1 commit into
Open
Trigger halide/Halide's upgrade-llvm workflow after publishing#8alexreinking wants to merge 1 commit into
alexreinking wants to merge 1 commit into
Conversation
Reuses the LLVM_UPDATER GitHub App so a new halide-llvm release notifies Halide immediately instead of waiting for its daily poll. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgrade-llvm.ymlin halide/Halide currently only runs on its own daily cron, pollinguv lock -P halide-llvmfor changes. Since build-llvm.yml now publishes new releases proactively (auto-discovering main + the two prior LLVM majors, see #7), it can push-notify Halide right after a successful publish instead of making it wait for the next poll.This adds a
trigger-halide-upgradejob that runs afterpublishsucceeds, mints a token for the LLVM_UPDATER GitHub App (the same oneupgrade-llvm.ymlalready runs as in Halide) scoped to theHaliderepo, and callsgh workflow run upgrade-llvm.yml --repo halide/Halide. This mirrors the existing reverse-direction pattern in Halide'spip.yml, which already callsgh workflow run rebuild-index.yml --repo halide/pypiafter its own nightly publish.Required manual setup (not doable from this PR)
LLVM_UPDATER_IDandLLVM_UPDATER_PRIVATE_KEYas secrets on halide/pypi (same values already configured on halide/Halide). The App doesn't need to be installed on halide/pypi — it only needs to be installed on halide/Halide, which it already is.contents/pull-requests, so this scope may need to be added in the App's settings.Until both are done, this job will fail (harmlessly — it's independent of
publish/rebuild-index, so it won't block releases), and Halide will keep relying on its daily poll in the meantime.Test plan
actionlint .github/workflows/build-llvm.ymlupgrade-llvm.ymlappears in halide/Halide's Actions tab shortly afterpublishcompletes🤖 Generated with Claude Code