Move one simplification call in lowering. - #9355
Open
mcourteaux wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9355 +/- ##
==========================================
- Coverage 70.14% 70.10% -0.04%
==========================================
Files 261 261
Lines 79396 79396
Branches 19358 19358
==========================================
- Hits 55690 55662 -28
- Misses 17892 17900 +8
- Partials 5814 5834 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Deadlocks exposed here fixed by #9372 |
mcourteaux
force-pushed
the
mcourteaux/move-simplify
branch
from
August 21, 2026 07:45
34b2370 to
84cc3b3
Compare
Contributor
Author
|
Waiting for #9372 to land to update this branch, but this seems to work now. @abadams please take note of Claude's initiative to disable a lower pass in LLVM 21, due to a bug fixed in 22 regarding SVE on ARM. I'll open a PR separately for this LLVM pass skip and remove the skips in all the tests to see if that makes the test suite pass. |
Member
|
Looks like it needs to be rebased. A bunch of unrelated changes are in it now. |
alexreinking
force-pushed
the
mcourteaux/move-simplify
branch
2 times, most recently
from
August 24, 2026 19:37
00a65a3 to
a00b0ef
Compare
alexreinking
approved these changes
Aug 24, 2026
alexreinking
changed the base branch from
main
to
mcourteaux/llvm21-load-elim-workaround
August 24, 2026 20:21
alexreinking
force-pushed
the
mcourteaux/move-simplify
branch
from
August 24, 2026 20:21
a00b0ef to
6049eb3
Compare
mcourteaux
force-pushed
the
mcourteaux/move-simplify
branch
2 times, most recently
from
August 27, 2026 10:44
b8fd264 to
7998d4d
Compare
mcourteaux
force-pushed
the
mcourteaux/move-simplify
branch
from
August 27, 2026 10:50
7998d4d to
33c2b35
Compare
Base automatically changed from
mcourteaux/llvm21-load-elim-workaround
to
main
August 27, 2026 15:15
Co-authored-by: Andrew Adams <andrew.b.adams@gmail.com> Move printing of the final simplification and call it 'after reaching conceptual stmt'
mcourteaux
force-pushed
the
mcourteaux/move-simplify
branch
from
August 27, 2026 15:15
33c2b35 to
6da6ed9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging some stuff not part of this PR, I spotted a missing simplification, which Andrew determined to be AFTER hoist_loop_invariant_xxx. This moves the simplification in the right spot.
Breaking changes
I hope none, let's see.
These do not necessarily disqualify a PR from being merged, but they should at
least be tagged with the
release_noteslabel.Checklist