feat: improved application usage#7
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves operational usability of ssltui by adding audit log export (TUI + dashboard), exposing the CRL via the public API, and improving dashboard UX (favicon + connection-loss handling). It also updates documentation and CI configuration to reflect the new/clarified behavior.
Changes:
- Add audit log CSV export from the TUI and the dashboard.
- Add
/api/v1/crl.pemendpoint (and document it) plus serve a favicon for the dashboard. - Improve dashboard resilience by hiding sensitive UI data when the backend is unreachable.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/convert_favicon.sh | Adds a helper script to generate favicon.ico from favicon.png. |
| ssltui/tui.py | Adds audit CSV rendering + export UI flow in the TUI; makes Save modal title configurable. |
| ssltui/images/favicon.png | Adds favicon source image (Git LFS pointer). |
| ssltui/images/favicon.ico | Adds generated favicon ICO (Git LFS pointer). |
| ssltui/api.py | Adds CRL download endpoint, dashboard audit download, favicon route, and connection-loss UI behavior. |
| README.md | Documents running ssltui serve in the background; updates dashboard capabilities list. |
| docs/API.md | Documents /api/v1/crl.pem. |
| CLAUDE.md | Fixes cron command example to use the renew subcommand. |
| .github/workflows/pr.yaml | Adds explicit workflow permissions; bumps CI Python version to 3.13. |
| .gitattributes | Adds *.ico to Git LFS tracking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1419
to
+1426
| @app.get("/api/v1/crl.pem") | ||
| def download_crl(): | ||
| crl = config.crl_path(root) | ||
| if not crl.exists(): | ||
| abort( | ||
| 404, description="CRL not found — no certificates have been revoked yet" | ||
| ) | ||
| return _pem_response(crl, "ca.crl") |
Comment on lines
+234
to
+235
| Reattach later with `tmux attach -t ssltui`. (`screen` or a systemd user | ||
| service work equally well.) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes