fix: security fixes based on findings#6
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens certificate common-name (CN) handling so untrusted CN inputs can’t be used for path traversal or for redirecting downloads via tampered stored paths, and documents the updated storage/input-validation behavior.
Changes:
- Added strict CN validation (
validate_cn) and strengthenedcert_dir()with resolve + containment checks. - Enforced CN validation in CA issuance and across API endpoints; download endpoints now re-derive file paths from
certs/<cn>/instead of trusting DB path strings. - Updated README directory layout and added API input-validation documentation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ssltui/config.py | Adds CN allow-list validation and containment-checked certificate directory derivation. |
| ssltui/ca.py | Validates CN during issuance and converts invalid CNs into CAError. |
| ssltui/api.py | Validates CN route/body inputs and confines downloads to certs/<cn>/ paths instead of DB-provided paths. |
| README.md | Documents SQLite-backed ca.db, CRL/token files, and CN validation / download confinement behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.