Skip to content

Display mailing lists badges in separate column #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moozzi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Display mailing lists badges in separate column #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/assets/stylesheets/components/topics.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ body.sidebar-collapsed .topics-table th.topic-title .sidebar-burger-button {
& .topic-replies {
width: 100px;
}
& .topic-mailing-lists,
& .topic-activity {
width: 150px;
}
Expand Down Expand Up @@ -274,6 +275,7 @@ a.topic-icon {
}

& th.activity-header,
& th.mailing-lists-header,
& td.topic-activity {
display: none;
}
Expand Down
3 changes: 0 additions & 3 deletions app/views/topics/_status_cell.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ td.topic-title.status-border class=status_class id=dom_id(topic, "status_cell")
.topic-title-icons
== icons_html
span
- topic_lists = @topic_mailing_lists_map&.dig(topic.id) || []
- if topic_lists.any?
= mailing_list_badges_html(topic_lists)
= link_to topic.title, topic_title_link(topic), class: "topic-link"
.topic-title-mobile
= link_to topic.title, topic_title_link(topic), class: "topic-link"
Expand Down
4 changes: 4 additions & 0 deletions app/views/topics/_topics.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

tr id=dom_id(topic) class="topic-row" data-topic-id=topic.id data-last-message-id=topic.last_message_id
= render partial: "topics/status_cell", locals: { topic: topic, state: {}, note_count: 0, team_readers: [], star_data: {} }
td.topic-mailing-lists data-label="Mailing Lists"
- topic_lists = @topic_mailing_lists_map&.dig(topic.id) || []
- if topic_lists.any?
= mailing_list_badges_html(topic_lists)
td.topic-activity data-label="Activity"
- replies_count = [topic.message_count - 1, 0].max
.activity-info.compact
Expand Down
1 change: 1 addition & 0 deletions app/views/topics/index.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
button.sidebar-burger-button type="button" aria-label="Expand sidebar" data-action="click->sidebar#toggle"
i.fa-solid.fa-bars aria-hidden="true"
| Topic
th.mailing-lists-header Mailing Lists
th.activity-header Activity
th.participants-header Participants
tbody#topics
Expand Down
1 change: 1 addition & 0 deletions app/views/topics/search.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
thead
tr
th.topic-title Topic
th.mailing-lists-header Mailing Lists
th.activity-header Activity
th.participants-header Participants
tbody#topics
Expand Down
Loading