Send user-bot DMs through Slack using the token in SSM - #214
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #212 (PR 2 of 2: the Lambda change; the SSM parameter went in with #213)
What changes did you make?
src/slack-token.ts: reads the bot token from/user-bot/slack-bot-token(named bySLACK_TOKEN_PARAMETER) with decryption, caches it per execution environment, and does not cache a failure. Anything not startingxoxb-, including Terraform's placeholder, is an errorhandler.ts: the sender is now resolved withgetSender()after the tag checks and beforeUpdateLoginProfile, so a missing or bad token leaves the user's password unchangedindex.ts: deployed handler now usesSlackMessageSender;StubMessageSenderstays for local runs and tests onlyindex.tswith SSM, IAM and Slack mocked. 51 testsWhy did you make the changes (we will use this info to test)?
Test user-bot Lambdashould pass on this PRDeploy user-bot Lambdashould run green. Until the token is set, a new user is refused with a loggedSlackTokenErrorand their password is unchanged