Harden local Git revision handling in triage and fix verification - #21
Open
manuelconcari-ai wants to merge 2 commits into
Open
manuelconcari-ai wants to merge 2 commits into
manuelconcari-ai wants to merge 2 commits into
Conversation
Zero matches from object enumeration, and an absent exact ref, establish only local absence. Shallow, single-branch, partial and outdated clones all lack objects that exist upstream, and no local command separates that from an invented identifier: in a local test a valid upstream commit was missing from each of those three clone shapes, with no promisor remote configured. Both reference files now say so in the resolution steps, split the decision accordingly, and keep only identifier-visible defects on the reporter's side: shape failures, an abbreviation matching two or more objects, a name that exists as both a tag and a branch, and objects that are not commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local triage examples pass a submitted revision to
git show, while related guidance usesgit logandgit diffwithout defining safe argument handling. In local fixtures, an option-shaped value such as--output=...changed Git's behavior even when passed as a single argument.This change adds instructions to the bulk-triage, single-report triage, and fix-verifier skills, with two
references/safe-local-git.mdfiles covering literal argument passing, exact ref lookup, unambiguous commit resolution, and reads using only resolved object IDs. It requires Git 2.45 or newer, disables lazy fetching throughout validation and reads, and distinguishes invalid identifiers from unavailable local verification.Validation: the patch changes five Markdown files and applies cleanly to current
main. Local Git fixtures cover option parsing, shell expansion, colliding object prefixes, ref-name fallback, object types, and partial-clone behavior, with resolution checks on SHA-1 and SHA-256 repositories.This is instruction hardening. The tests establish Git behavior and patch applicability; they do not demonstrate exploitation through a deployed agent, permission bypass, or deterministic compliance by a model. No executable helper or runtime permission change is included.