Skip to content

Split knowledge source DTOs #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
Jun 29, 2026
Merged

Split knowledge source DTOs #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 7 additions & 216 deletions packages/elf-storage/src/knowledge/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
mod sources;

pub use self::sources::{
KnowledgeDocChunkSource, KnowledgeDocSource, KnowledgeEventSource, KnowledgeNoteSource,
KnowledgeProposalSource, KnowledgeRelationSource, KnowledgeRelationSourcesFetch,
};

use serde_json::Value;
use sqlx::FromRow;
use time::OffsetDateTime;
Expand Down Expand Up @@ -111,222 +118,6 @@ pub struct KnowledgePageLintFindingInsert<'a> {
pub now: OffsetDateTime,
}

/// Parameters for fetching graph relation sources for knowledge pages.
pub struct KnowledgeRelationSourcesFetch<'a> {
/// Tenant that owns the relation sources.
pub tenant_id: &'a str,
/// Project that owns the relation sources.
pub project_id: &'a str,
/// Agent requesting source readback, when visibility should be caller-scoped.
pub agent_id: Option<&'a str>,
/// Scopes allowed by the caller read profile.
pub allowed_scopes: &'a [String],
/// Shared owner/scope grant keys readable by the caller.
pub shared_scope_keys: &'a [String],
/// Whether private scope is readable by the caller.
pub private_allowed: bool,
/// Graph fact identifiers to fetch.
pub fact_ids: &'a [Uuid],
}

/// Authoritative note source row used by the knowledge page rebuilder.
#[derive(Debug, FromRow)]
pub struct KnowledgeNoteSource {
/// Note identifier.
pub note_id: Uuid,
/// Agent that owns the note.
pub agent_id: String,
/// Note scope.
pub scope: String,
/// Note type.
pub note_type: String,
/// Optional note key.
pub key: Option<String>,
/// Note text.
pub text: String,
/// Note importance.
pub importance: f32,
/// Note confidence.
pub confidence: f32,
/// Note status.
pub status: String,
/// Note creation timestamp.
pub created_at: OffsetDateTime,
/// Note update timestamp.
pub updated_at: OffsetDateTime,
/// Optional note expiry timestamp.
pub expires_at: Option<OffsetDateTime>,
/// Note embedding version.
pub embedding_version: String,
/// Opaque note source reference.
pub source_ref: Value,
}

/// Durable add_event audit source row used by the knowledge page rebuilder.
#[derive(Debug, FromRow)]
pub struct KnowledgeEventSource {
/// Ingest decision identifier.
pub decision_id: Uuid,
/// Agent that wrote the audited event-derived note decision.
pub agent_id: String,
/// Scope associated with the audited decision.
pub scope: String,
/// Ingestion pipeline name.
pub pipeline: String,
/// Event-derived note type.
pub note_type: String,
/// Optional note key.
pub note_key: Option<String>,
/// Note identifier affected by the decision, when persisted.
pub note_id: Option<Uuid>,
/// Policy decision.
pub policy_decision: String,
/// Note operation.
pub note_op: String,
/// Optional reason code.
pub reason_code: Option<String>,
/// Structured audit details.
pub details: Value,
/// Audit timestamp.
pub ts: OffsetDateTime,
}

/// Authoritative graph relation source row used by the knowledge page rebuilder.
#[derive(Debug, FromRow)]
pub struct KnowledgeRelationSource {
/// Graph fact identifier.
pub fact_id: Uuid,
/// Agent that wrote the fact.
pub agent_id: String,
/// Fact scope.
pub scope: String,
/// Subject canonical text.
pub subject: String,
/// Optional subject kind.
pub subject_kind: Option<String>,
/// Predicate text.
pub predicate: String,
/// Optional object entity canonical text.
pub object_entity: Option<String>,
/// Optional object entity kind.
pub object_kind: Option<String>,
/// Optional scalar object value.
pub object_value: Option<String>,
/// Fact validity window start.
pub valid_from: OffsetDateTime,
/// Fact validity window end, when historical.
pub valid_to: Option<OffsetDateTime>,
/// Fact update timestamp.
pub updated_at: OffsetDateTime,
/// Evidence notes linked to this fact.
pub evidence_notes: Value,
}

/// Reviewed consolidation proposal source row used by the knowledge page rebuilder.
#[derive(Debug, FromRow)]
pub struct KnowledgeProposalSource {
/// Consolidation proposal identifier.
pub proposal_id: Uuid,
/// Parent consolidation run identifier.
pub run_id: Uuid,
/// Agent that registered the proposal.
pub agent_id: String,
/// Proposal kind.
pub proposal_kind: String,
/// Proposal apply intent.
pub apply_intent: String,
/// Proposal review state.
pub review_state: String,
/// Serialized proposal source references.
pub source_refs: Value,
/// Serialized proposal source snapshot.
pub source_snapshot: Value,
/// Serialized proposal lineage.
pub lineage: Value,
/// Serialized proposal diff.
pub diff: Value,
/// Proposal confidence.
pub confidence: f32,
/// Unsupported claim flags.
pub unsupported_claim_flags: Value,
/// Contradiction markers.
pub contradiction_markers: Value,
/// Staleness markers.
pub staleness_markers: Value,
/// Derived target reference.
pub target_ref: Value,
/// Proposed derived payload.
pub proposed_payload: Value,
/// Proposal update timestamp.
pub updated_at: OffsetDateTime,
}

/// Source Library document row used by the knowledge page rebuilder.
#[derive(Debug, FromRow)]
pub struct KnowledgeDocSource {
/// Document identifier.
pub doc_id: Uuid,
/// Agent that captured the document.
pub agent_id: String,
/// Document scope.
pub scope: String,
/// Document type.
pub doc_type: String,
/// Document lifecycle status.
pub status: String,
/// Optional document title.
pub title: Option<String>,
/// Document source reference.
pub source_ref: Value,
/// Persisted document content.
pub content: String,
/// Persisted byte length.
pub content_bytes: i32,
/// Whole-document content hash.
pub content_hash: String,
/// Document creation timestamp.
pub created_at: OffsetDateTime,
/// Document update timestamp.
pub updated_at: OffsetDateTime,
}

/// Source Library document chunk row used by the knowledge page rebuilder.
#[derive(Debug, FromRow)]
pub struct KnowledgeDocChunkSource {
/// Chunk identifier.
pub chunk_id: Uuid,
/// Parent document identifier.
pub doc_id: Uuid,
/// Agent that captured the document.
pub agent_id: String,
/// Document scope.
pub scope: String,
/// Document type.
pub doc_type: String,
/// Document lifecycle status.
pub status: String,
/// Optional document title.
pub title: Option<String>,
/// Document source reference.
pub source_ref: Value,
/// Whole-document content hash.
pub doc_content_hash: String,
/// Document update timestamp.
pub doc_updated_at: OffsetDateTime,
/// Zero-based chunk index.
pub chunk_index: i32,
/// Inclusive start byte offset.
pub start_offset: i32,
/// Exclusive end byte offset.
pub end_offset: i32,
/// Chunk text.
pub chunk_text: String,
/// Chunk content hash.
pub chunk_hash: String,
/// Chunk creation timestamp.
pub chunk_created_at: OffsetDateTime,
}

/// Searchable knowledge page section row with page and lint metadata.
#[derive(Debug, FromRow)]
pub struct KnowledgePageSearchRow {
Expand Down
Loading