fix(layout): hug fits content for groups too + CI actions v6 (0.0.44)#46
Merged
Conversation
…(0.0.44) v0.0.43 floored content-basis FILL meters at min-content, but GROUPS (a dropped template / nested layout — e.g. the Network widget) were excluded, AND the group "hug" option set basis:undefined (skipping the floor entirely). So hugging a group still clipped to its stored size — the reported Network "hug still clipping". - flowStyle.ts: include groups in the content-basis min-content floor — a hugged group sits at max(stored size, its content). - Inspector.tsx: the group size control's "hug" now sets basis:'content' (was undefined) and is relabelled "hug — fit content", so the floor is actually reachable from the UI. - CI: bump actions/checkout + actions/setup-node v4 → v6 (clears the Node 20 deprecation). Verified: type-check, lint, 1318 unit tests (flowStyle group test added), build, and the real-browser e2e (32 passed). An existing Network widget saved at fr basis should be set to "hug — fit content" to pick this up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to v0.0.43: the Network widget (a group) still clipped at hug. Two reasons:
min-contentfloor was scoped to fill-meter leaves — groups were excluded.basis: undefined, which skips the floor entirely (falls back to the storedsize). So hugging a group never floored at content — it pinned to the stale stored size (your saved widget's was104, content ~148).Fix
flowStyle.ts— include groups in thecontent-basismin-contentfloor. A hugged group now sits atmax(stored size, its content).Inspector.tsx— the group "hug" option setsbasis: 'content'(wasundefined) and is relabelled "hug — fit content", so the floor is reachable from the UI.actions/checkout+actions/setup-nodebumped v4 → v6 (clears the Node 20-deprecation warning) in both workflows.Verification
For an existing Network widget saved at
frbasis: set it to "hug — fit content" to pick up the floor (or it can stayfrand be given more room).🤖 Generated with Claude Code