Repository navigation
Fix potential NPE in Utility.makeTemporaryDirectory - #10414
Merged
Merged
Conversation
Member
|
Thanks - it is intended to be removed soon, but the fix is simple and maybe it will briefly save someone else a headache. |
niloc132
added
the
ready
niloc132
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method com.google.gwt.util.tools.Utility.makeTemporaryDirectory violates its JavaDoc because the baseDir cannot be null anymore since #10083.
I found this while running CodeServer from an older gwt-codeserver.jar with a new gwt-dev.jar on classpath.
Fixing my classpath avoids this issue so I actually don't mind if you merge this trivial change or close it since the Utility class is planed for removal anyways.