Repository navigation
Remove very old FireFox version checks - #10308
Conversation
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
I have a local branch that was also attempting to do this, I'll make a PR to your PR and see if we can't get all the fixes in
|
Take a look at zbynek#6 when you get the chance, I think it completes this work. |
| // Works around https://bugzilla.mozilla.org/show_bug.cgi?id=548397 | ||
| return 0; | ||
| } | ||
| return parseInt(style.marginLeft, 10) + parseInt(style.borderLeftWidth, 10); |
There was a problem hiding this comment.
Note that I think this might be wrong in other browsers - the superclass only returns 0, mozilla is the only impl that actually reads values from the dom. Ditto offsettop below. Probably out of scope here, just seeking to remove this extra null check.
There was a problem hiding this comment.
The FF implementation matches the name, but the WebKit implementation results in more sensible behavior.
- go to https://samples.gwtproject.org/samples/Showcase/Showcase.html#!CwBasicPopup
- run
document.documentElement.style.margin="100px";in the console - click the image
Expected: popup centered
Actual: popup too far left in FF (but centered in WebKit)
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
"Self review" of a sort - I can push you a commit if you'd prefer
| /** | ||
| * Implementation of {@link CellTable} used by Firefox. | ||
| */ | ||
| @SuppressWarnings("unused") | ||
| private static class ImplMozilla extends Impl { |
There was a problem hiding this comment.
Looking more carefully, maybe we should keep the class with no contents, as the Trident classes, just in case someone has a custom replace-with
There was a problem hiding this comment.
The class does not change behavior in any existing browser, so the fix for anyone using it is to simply remove the replace-with. With the Trident stuff it might be possible (though very unlikely) that someone depends on the changes in behavior it provides. I think it's fine to remove this.
33ab6de to
0e9ec31
Compare
zbynek
added
Category-UI
ready
Co-authored-by: Colin Alworth <colin@vertispan.com>
3095efa to
f71fb5e
Compare
2 participants
Removes some very old checks, partial fix for #10295