Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new shared trash-bin management module for deleted files, makes related configuration updates, and adds favicon support across all HTML assets. The most important changes are the addition of the
trash.rsmodule, updates to expose and use its API, and improvements to the user interface with favicons.Trash-bin management
trash.rsmodule implementing a thread-safeTrashManagerfor managing deleted files in a shared.bh_filesync/trash/directory, including moving files to trash, restoring, purging, and listing trash entries. (crates/core/src/trash.rs)TrashEntryandTrashManagertypes from the core library for use by other modules. (crates/core/src/lib.rs) [1] [2]trash_expiry_days,full_scan_interval_secs). (config.toml)Frontend/UI improvements
bytehive-icon.svg,bytehive_icon_32x32.png) to all HTML assets, ensuring a consistent brand appearance in browser tabs. (crates/core/assets/*.html) [1] [2] [3] [4] [5] [6]crates/core/src/html.rs,crates/core/src/http.rs) [1] [2] [3] [4]Minor UI/JS style improvements
portal.html. (crates/core/assets/portal.html) [1] [2] [3]