Skip to content

feat: software-mode external texture support for D3D11-hooked apps - #2

Closed
guide-nhant wants to merge 3 commits into
sbi_fx_pc/flutter_3.29.3from
sbi_fx_pc/flutter_3.29.3-patch
Closed

feat: software-mode external texture support for D3D11-hooked apps#2
guide-nhant wants to merge 3 commits into
sbi_fx_pc/flutter_3.29.3from
sbi_fx_pc/flutter_3.29.3-patch

Conversation

@guide-nhant

@guide-nhant guide-nhant commented May 28, 2026

Copy link
Copy Markdown

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds software-renderer support for external pixel-buffer textures so the Texture widget can display plugin-provided frames even when the engine falls back to software rasterization (e.g., when ANGLE/D3D11 isn’t available on Windows).

Changes:

  • Extends the embedder API (FlutterSoftwareRendererConfig) with an optional software external-texture callback returning a CPU pixel buffer.
  • Wires the Windows software renderer config to ask the Windows texture registrar for pixel buffers in software mode.
  • Introduces a new software external texture implementation (EmbedderExternalTextureSoftware) and integrates it into the external texture resolver.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar.h Adds software populate API and stores pixel-buffer callbacks for software rendering.
engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar.cc Registers pixel-buffer callbacks for software path; implements PopulateTextureSoftware; updates unregister behavior.
engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc Sets external_texture_frame_callback in the software renderer config for Windows.
engine/src/flutter/shell/platform/embedder/embedder.h Adds FlutterSoftwarePixelBuffer + software external texture callback fields to software renderer config.
engine/src/flutter/shell/platform/embedder/embedder.cc Creates an external texture resolver backed by the new software external texture callback when in software mode.
engine/src/flutter/shell/platform/embedder/embedder_external_texture_software.h Declares the software external texture implementation.
engine/src/flutter/shell/platform/embedder/embedder_external_texture_software.cc Implements software external texture rendering via raster SkImage creation from CPU pixels.
engine/src/flutter/shell/platform/embedder/embedder_external_texture_resolver.h Adds software external texture callback plumbing to the resolver.
engine/src/flutter/shell/platform/embedder/embedder_external_texture_resolver.cc Resolves textures using the software implementation when configured.
engine/src/flutter/shell/platform/embedder/BUILD.gn Adds the new software external texture sources to the embedder build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar.cc Outdated
Comment thread engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar.h Outdated
guide-nhant and others added 2 commits May 28, 2026 11:48
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@guide-nhant

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants