feat: software-mode external texture support for D3D11-hooked apps - #2
Closed
guide-nhant wants to merge 3 commits into
Closed
feat: software-mode external texture support for D3D11-hooked apps#2guide-nhant wants to merge 3 commits into
guide-nhant wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds software-renderer support for external pixel-buffer textures so the Texture widget can display plugin-provided frames even when the engine falls back to software rasterization (e.g., when ANGLE/D3D11 isn’t available on Windows).
Changes:
- Extends the embedder API (
FlutterSoftwareRendererConfig) with an optional software external-texture callback returning a CPU pixel buffer. - Wires the Windows software renderer config to ask the Windows texture registrar for pixel buffers in software mode.
- Introduces a new software external texture implementation (
EmbedderExternalTextureSoftware) and integrates it into the external texture resolver.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar.h | Adds software populate API and stores pixel-buffer callbacks for software rendering. |
| engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar.cc | Registers pixel-buffer callbacks for software path; implements PopulateTextureSoftware; updates unregister behavior. |
| engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc | Sets external_texture_frame_callback in the software renderer config for Windows. |
| engine/src/flutter/shell/platform/embedder/embedder.h | Adds FlutterSoftwarePixelBuffer + software external texture callback fields to software renderer config. |
| engine/src/flutter/shell/platform/embedder/embedder.cc | Creates an external texture resolver backed by the new software external texture callback when in software mode. |
| engine/src/flutter/shell/platform/embedder/embedder_external_texture_software.h | Declares the software external texture implementation. |
| engine/src/flutter/shell/platform/embedder/embedder_external_texture_software.cc | Implements software external texture rendering via raster SkImage creation from CPU pixels. |
| engine/src/flutter/shell/platform/embedder/embedder_external_texture_resolver.h | Adds software external texture callback plumbing to the resolver. |
| engine/src/flutter/shell/platform/embedder/embedder_external_texture_resolver.cc | Resolves textures using the software implementation when configured. |
| engine/src/flutter/shell/platform/embedder/BUILD.gn | Adds the new software external texture sources to the embedder build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.