Update GitHub recommendations#187
Open
NovemberTang wants to merge 3 commits into
Open
Conversation
cation of repo genesis 2 years ago
tjsilver
reviewed
Aug 13, 2025
| By default, new repositories are open to the department via `Internal` visibility (for read access). | ||
|
|
||
| (Existing `Private` repositories may achieve the same effect by additionally granting read access to [`@guardian/guardian-developers-read`][gh-read]. This approach is not recommended since GitHub's introduction of `Internal` visibility.) | ||
| (Existing `Private` repositories may be converted to `Internal` if their contents is not particularly sensitive) |
Contributor
There was a problem hiding this comment.
Should we not leave in the bit about granting read access on private repos, for those who can't convert to 'internal'?
Contributor
Author
There was a problem hiding this comment.
I hadn't really considered this! Are there scenarios where it's not possible to convert a repo to from private to internal?
Contributor
There was a problem hiding this comment.
Well I was just going by the bit where it says "if their contents is not particularly sensitive" - I guess I mean the scenarios when the contents are particularly sensitive? If we don't think there are any contexts like that, maybe we could remove that caveat?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being recommended?
interactiveas a valid status topicWhat's the context?
Since we are now tracking the number of repos that don't have a production status, I'm updating the recommendations on how to classify repos.
While I'm here, I've updated some other parts of the docs that are confusing or less relevant.
With the upcoming security training, it's now more important that this information is up-to-date.