Skip to content

Adds gu:tool and gu:application-repo definitions to AWS tags glossary#184

Open
SHession wants to merge 1 commit into
mainfrom
document-gu-application-repo-and-tool-tags
Open

Adds gu:tool and gu:application-repo definitions to AWS tags glossary#184
SHession wants to merge 1 commit into
mainfrom
document-gu-application-repo-and-tool-tags

Conversation

@SHession

@SHession SHession commented May 19, 2025

Copy link
Copy Markdown
Contributor

What is being recommended?

This PR adds to the set of standard AWS tags to include gu:tool and gu:application-repo. Hopefully the text content is descriptive enough to explain their use.

What's the context?

Related to the tools audit work and this comment: guardian/service-catalogue#1525 (comment)

These new tags are intended to make it easier to map between the resources that make up a project.

Note

The recommendations in this repository are intended to share engineering best practices for all of Product & Engineering (P&E) in the open.

Some considerations:

  • Should this really be an ADR in another repository?
  • Have you sought review widely enough (Developer Experience, Heads of Engineering)?
  • If it is security related, should you consult with Information Security?

Comment thread AWS.md
* `CODE` for pre-production
* `INFRA` for infrastructure or singleton resources e.g. [elasticsearch-node-rotation](https://github.com/guardian/elasticsearch-node-rotation)
* `App` - the individual service e.g. `image-loader`
* `gu:tool` - the tool which the resource belongs to, similar to stack but more specific e.g. Composer, Workflow, Grid

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SHession this seems only applicable to tools rather than to all resource. Perhaps the description could reflect this?

Comment thread AWS.md
* `App` - the individual service e.g. `image-loader`
* `gu:tool` - the tool which the resource belongs to, similar to stack but more specific e.g. Composer, Workflow, Grid
* `gu:repo` - the GitHub repository where the resource's definition can be found
* `gu:application-repo` - the GitHub repository where the application code can be found

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify the difference between gu:repo and gu:application-repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants