Fade out the advertiser logo on playing a hosted video#15829
Merged
Conversation
i-hardy
force-pushed
the
ih/hosted-video-icon-fade
branch
from
6df82f3 to
9bff27c
Compare
i-hardy
force-pushed
the
ih/hosted-video-icon-fade
branch
3 times, most recently
from
9912b33 to
1cc1f1d
Compare
i-hardy
force-pushed
the
ih/hosted-video-icon-fade
branch
from
1cc1f1d to
d4d795b
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
approved these changes
May 12, 2026
Comment on lines
+171
to
+172
| // Logo fading is an exclusive feature for hosted video pages at certain breakpoints | ||
| // This component only needs rehydration on the video layout |
github-actions
Bot
removed
the
run_chromatic
Co-authored-by: Charlotte <43961396+cemms1@users.noreply.github.com>
i-hardy
force-pushed
the
ih/hosted-video-icon-fade
branch
from
f56a68d to
0dc4630
Compare
github-actions
Bot
removed
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This fades out the brand logo in the header when a hosted video is played (and fades it back in on pause), below the wide breakpoint where the logo overlays the video.
Why?
This is a feature of the hosted video pages in frontend, as otherwise the logo blocks a portion of the playing video and this looks awkward.
Screenshots
video_logo_fade.mov