Cricket match header result#15824
Merged
Merged
Conversation
Jakeii
force-pushed
the
jlk/cricket-match-header-result
branch
from
3a0081e to
4d6222c
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
SiAdcock
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15684
What does this change?
Add types and UI for the cricket match result based on the data from PA, most of the time there is a nice description like "Australia win by an innings and 47 runs" which we can use, but sometimes there isn't so we can fallback to one constructed from the data available.
I've used the same style as the "comment" from the football header which is used for football results:
This is different from the original idea of the winning score at the bottom of the team column as cricket results can be varied and complex:
Examples I've come across already
Screenshots