Repository navigation
Cap the text toolbar at eight colours - #219
Open
grunion-ai wants to merge 1 commit into
Open
grunion-ai wants to merge 1 commit into
grunion-ai wants to merge 1 commit into
Conversation
The swatch row listed every colour on any row in the deck, so library.html offered 44. Bar fills and run backgrounds counted too: the row test ignored whether a row held text, and the run pattern matched background-color. The row now holds the role colours first, then the text colours rows use most, up to eight. Colours already on rows keep rendering. ponytail: - template.html deckColors: SWATCH_MAX is a fixed 8 with no per-deck setting, and a colour past the cap cannot be reapplied from the toolbar. Upgrade path: a palette key in style.json if a brand needs more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The text toolbar shows at most eight colour swatches: the role colours first, then the text colours rows use most. Colours already on rows keep rendering.
Why
The swatch row listed every colour on any row in the deck, so
library.htmloffered 44. Bar fills and run backgrounds counted as text colours too:deckColorsdid not check that a row held text, and its run pattern matchedbackground-color.Limit
The cap is fixed at eight, with no per-deck setting. A colour past the cap still renders but cannot be reapplied from the toolbar. If a brand needs more, the upgrade path is a palette key in
style.json.Verified
test/editor.test.mjs. It fails on the old template with 36 swatches and passes on this branch.node --test test/**/*.test.mjs: 729 of 729 pass, none skipped, rebased on 0ecc47d.library.html, slide 27, Stat row selected: 44 swatches before, 8 after, measured in Chromium. No screenshot is attached becauseghcannot upload images; Kyle has the before and after images.deck.htmlandlibrary.htmlare rebuilt from the changed template.Existing decks keep the old toolbar until they are rebuilt with
create --from.🤖 Generated with Claude Code