fix(dev): an aggregated stylesheet swaps its dependents alone - #94
Merged
Merged
Conversation
A non-partial stylesheet that is only reached through another stylesheet's imports — recorded as a dependency, never compiled as an entry — published its own URL too, which no `<link>` carried. The client turned that miss into a refresh of every stylesheet, and the targeted swap that followed in the same batch raced it into two `<link>` elements for one sheet. Such a stylesheet now names its dependents alone, an edit outside every mount that the index attributes to stylesheets hot-swaps them instead of reloading the page, and the client ignores a named stylesheet the page does not carry and supersedes a swap still in flight.
gronke
force-pushed
the
live-reload-attribution
branch
from
September 7, 2026 09:15
156407b to
7e43301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes_for: a non-partial.scssthat has recorded dependents but was never recorded as an entry (DependencyIndex::is_entry) publishes its dependents alone; an entry keeps naming its own URL.changes_for: an edit outside every mount, or of an unknown kind, that the index attributes to stylesheets publishes those without the trailing bareChange::reload()(a vendored partial on a load path hot-swaps instead of reloading).live.js: a named stylesheet that no<link>on the page carries is a logged no-op — onlyurl: nullfans out; a swap still in flight for the same link is superseded by the newer change (WeakMap/WeakSetbookkeeping), so rapid edits never leave duplicate links.Processorsgainedexternal,dtsandlibrary(breaking for struct literals).