full includes bundle; lean is the previous full - #92
Merged
Merged
Conversation
gronke
marked this pull request as draft
September 4, 2026 11:20
The released `web-modules` binary ships the rolldown `--bundle` path, but the library's `full` aggregate excluded it, so the action's from-source install built a binary without `bundle: true` and every from-source or dogfood invocation spelled `--features "full bundle"`. `full` is now the complete toolchain (`lean` plus `bundle`), and the previous set lives on as `lean`, which docs.rs and the MSRV job use instead: docs.rs keeps the heavy second-oxc tree out of the doc build, and rolldown declares no rust-version, so its unknown MSRV must not gate the declared one. release.yml and action.yml build `--features full` again, now meaning the complete CLI; a from-source install matches the download. CI's separate `bundle npm cli` clippy/test steps fold into the workspace `full` runs, the feature-isolation check gains a standalone `lean` build, and the bundle-demo dogfood mirrors the released binary with plain `--features full`.
gronke
changed the title
gronke
changed the title
gronke
force-pushed
the
fix/action-from-source-bundle
branch
from
September 4, 2026 12:18
966fdb7 to
c944833
Compare
gronke
marked this pull request as ready for review
September 4, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo.toml: the newleanaggregate holds the previousfullset, andfull = ["lean", "bundle"].lean. The rolldown tree stays out of the doc build, and rolldown declares norust-version, so its unknown MSRV must not gate the declared one.release.ymlandaction.ymlbuild--features full, now meaning the complete CLI. The comment rewrite also resolves the double-"so" nit.ci.yml: the separatebundle npm cliclippy/test steps are subsumed by the workspacefullruns and deleted. The feature-isolation check gains a standaloneleanbuild, and the bundle-demo dogfood runs--features full.fullnow compile the rolldown tree;leanis the previous behavior.