Add media models to the AI catalogue - #1014
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe PR expands AI model catalogue contracts and documentation, adds video pricing with input-image surcharges, exports video and 3D catalogues, adds provider logos, and extends the models page with video, sound-effect, and 3D sections. ChangesAI model catalogue and pricing
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The catalogue and presentation updates have no supplied concrete correctness, security, availability, or deployment risk at the current head, so no actionable merge-blocking risk remains after normal checks. Sequence Diagram(s)sequenceDiagram
participant ModelsPage
participant ai.video
participant VideoCatalogue
participant ProviderBindings
ModelsPage->>ai.video: listed_models()
ai.video->>VideoCatalogue: read enabled video cards
VideoCatalogue->>ProviderBindings: resolve provider pricing
ProviderBindings-->>ModelsPage: return rates and input-image surcharges
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5abd34a199
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {bindings.map((binding) => { | ||
| const prices = Object.values(binding.pricing.usd_per_second).flatMap( |
There was a problem hiding this comment.
Stop publishing ungrounded OpenRouter video rates
When visitors view Veo or Seedance on /ai/models, this loop renders their OpenRouter bindings as per-second prices, even though .agents/skills/ai-models/SKILL.md explicitly states that OpenRouter exposes only $0/MTok for video and has no usable per-second meter, and instructs maintainers to leave such bindings out. Consequently the page presents $0.400/s and $0.067/s as “grounded native pricing” without a supported meter; omit these bindings from the catalogue/display until a verifiable per-second rate exists.
Useful? React with 👍 / 👎.
Summary
/ai/modelsSupport boundary
Only models Grida can actually select and call enter the video catalogue. Gemini Omni and Seedance 2.5 are intentionally absent until their real execution and metering contracts are integrated.
Sound-effect and 3D records remain explicitly
staged: they are available to the dedicated Desktop compatibility playground, but catalogue presence does not claim web generation support.Review fixes
listed: falsestructurally invalid for video cardsstaged→listedlifecycle changesValidation
@grida/ai-modelsbuild@grida/ai-modelstests: 64/64@grida/ai-modelstypecheck@grida/react-iconsbuild and typecheckgit diff --check/ai/modelsrequest: HTTP 200Reviewer notes