Repository navigation
Network diagrams theo mô hình AgentBase VPC + bắt buộc memory headers - #1
Merged
Merged
Conversation
…tracing - A2A server: GET /.well-known/agent-card.json (skills travel-planning, personalization, streaming), POST /a2a JSON-RPC message/send + message/stream (SSE) - contextId A2A map vào thread_id → hội thoại A2A có memory - LangFuse: migrate langfuse-langchain 2.x (legacy) → langfuse v4 (OTel): _lf_scope() propagate_attributes (trace name/user/session/tags cho root + mọi child observation) + _lf_callback() CallbackHandler tạo trong scope - requirements: langfuse>=4.0,<5 (resolved 4.16.0); tests/test_a2a.py (10 test); README: section A2A + Observability
…se flows - docs/network-layers.html (archify): bản đồ layer Internet → Cloud VPC (agents public + VPC mode, gateway, stock-mcp, LangFuse) → on-prem KH - docs/usecase-flows.html (archify): 3 use case — public (egress Internet qua gateway · APIKEY), private (agent VPC mode không egress, MCP on-prem qua route CIDRs), A2A - README: section 'Kiến trúc mạng theo layer' — mermaid + bảng use case public/private + ghi chú demo live vs pattern platform
…e case - agentbase-network-map.html: 1 block AgentBase Runtime đặt ở public subnet hoặc private subnet (VPC KH, vServer) — break ra LLM AIP / Memory+Identity / MCP Gateway; từ gateway 3 nhóm MCP: Internet (tavily) · Cloud (stock-mcp) · On-Premise (route CIDRs qua Site-to-Site VPN / vNG Cloud Interconnect) - usecase-public-cloud.html: UC1 public mode (demo live) - usecase-private-onprem.html: UC2 private — không Tavily/Internet, runtime VPC mode, LLM/Memory qua platform network, MCP on-prem qua VPN + route - README: master mermaid AWS-style + bảng so sánh UC1/UC2 + các bước nối on-prem ↔ VPC (VPN/Interconnect → route table → routeCidrs) - xóa 2 diagram cũ (network-layers, usecase-flows) — thay bằng bộ mới
- generator docs/generate_aws_diagrams.py (SVG thuần): icon tile gradient màu theo category AWS (compute cam / network tím / ml teal / db magenta), VPC + subnet nét đứt kèm tab label, private subnet có khóa, VPC route table, panel navy Corporate Data Center, line Direct Connect cam + Site-to-Site VPN đỏ nét đứt, mũi tên + label halo - agentbase-network-map.html: runtime ở public/private subnet + break-out LLM/Memory/Gateway + 3 nhóm MCP (Internet/Cloud/On-Prem) - usecase-public-cloud.html · usecase-private-onprem.html: 2 use case - nút Download PNG (2x) / SVG trong trang; bỏ JSON archify cũ
- mọi mũi tên đi ngang/dọc theo lưới, 0-1 góc rẽ, không chéo nhau - canh hàng tuyệt đối: runtime-public ↔ LLM cùng hàng (arrow thẳng), Memory/Gateway/stock margin đều 88px, VPN tile cùng hàng gateway - rt fan-out 3 nhánh song song (y 425/437/449) — bus gọn như AWS console - rtvpc → gateway: đường ngang thẳng vào mép trái; gateway → tavily elbow qua hành lang x=1010; DX/VPN 2 line song song xuống panel on-prem - sửa tile đè tab label, arrow không chạm tile (đã soi screenshot từng hình)
- docs/network: 5 diagram AWS-style dùng icon GreenNode (bản đồ tổng với gateway Public/Private, UC Public, UC MCP trong VPC KH, UC on-prem, thông mạng on-prem); Agent Runtime + MCP Gateway nằm trong AgentBase VPC - Bỏ các diagram HTML cũ (sai concept runtime nằm trong VPC KH) - Thiếu header X-GreenNode-AgentBase-User-Id/Session-Id → HTTP 400; /a2a không dùng chung actor "a2a" nữa - README: pipeline MCP Governance, Sidecar LLM Proxy, Security Settings - Xoá dead code: _trim_messages (thay bằng _trim_history dùng chung với checkpointer), search_facts, import thừa Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hình AWS-style dùng icon GreenNode, sinh từ sample-travel-buddy/docs/network/build_diagrams.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tóm tắt
docs/network: 5 diagram AWS-style dùng icon GreenNode
Agent Runtime + MCP Gateway nằm trong AgentBase VPC, đúng theo docs Private Networking.
Bỏ các diagram HTML cũ (vẽ runtime nằm trong VPC KH là sai concept).
Thiếu header
X-GreenNode-AgentBase-User-Id/Session-Id→ HTTP 400./a2akhông dùng chung actor"a2a"nữa (tránh trộn memory giữa người dùng).README: pipeline MCP Governance (Inbound Auth → Policy Group → Connector Outbound Auth), Sidecar LLM Proxy, Security Settings của Runtime, link tới org/repo mới
GreenNode-Samples/sample-*.Xoá dead code:
_trim_messages(thay bằng_trim_historydùng chung với checkpointer),search_facts, import thừa.Test
pytest tests -q→ 28 passeddocs/network/build_diagrams.py, không có line cắt chữ🤖 Generated with Claude Code