Repository navigation
Fix red upgrade CI: HITL test must not depend on a re-asked card keeping its id - #12
Merged
Merged
Conversation
…rrupt id langgraph 1.2.20 issues a new id there; the contract is that the client echoes the id it was given. Fixes the red upgrade CI job (it re-locks an old project and picked up 1.2.20). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
upgradejob has been red on main since the dependency drift of 2026-11-09 (also on a manual run of main, so not caused by PR #11).Cause (reproduced locally, then isolated by pinning): the job re-locks an old project, which now resolves
langgraph1.2.20 while the shippeduv.lockpins 1.2.18. With 1.2.20, when the approval node asks a card again (stale decisions backstop), the interrupt gets a new id; with 1.2.18 it kept the old one.test_approval_node_reasks_instead_of_applying_unknown_idsasserted the old id.Fix: the test no longer asserts id equality (the documented contract is that each card has its own id and the client echoes the one it was given; the test still resumes with the id it receives). No app code changed. Full
test_upgrade.py --pytestpasses locally: 606 passed with langgraph 1.2.20, ruff clean.Not done: the shipped
uv.lockstill pins langgraph 1.2.18, so fresh projects test against the old behaviour; bumping the lock is a separate change.🤖 Generated with Claude Code