Repository navigation
feat(task)!: make doubling the default growth strategy - #192
Draft
greenhat616 wants to merge 1 commit into
Draft
greenhat616 wants to merge 1 commit into
greenhat616 wants to merge 1 commit into
Conversation
This was referenced Nov 8, 2026
greenhat616
force-pushed
the
feat/hardening-30-default-doubling
branch
from
November 13, 2026 07:44
ea69115 to
a20ea81
Compare
greenhat616
marked this pull request as draft
November 13, 2026 08:55
Doubling is now the only growth strategy, so every download grows by doubling, restarts slow and silent runners and hedges a stalled range at the endgame. Legacy, its task-speed split size and the split actions only it used are removed, and the per-runner rates are always sampled. The growth bench runs Doubling alone; the last comparison with Legacy stays in the design notes. BREAKING CHANGE: the unstable-strategy feature, GrowthStrategy, TaskOptions::growth_strategy and TaskBuilder::growth_strategy are removed; doubling is the only growth strategy.
greenhat616
force-pushed
the
feat/hardening-30-default-doubling
branch
from
November 13, 2026 22:25
a20ea81 to
50c5a15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C14 (T15, PR-7b) of the download strategy hardening stack. It is stacked on #191, the silent-runner restart, and that branch is its base. The design notes are in §14.20.
Why
T15 switches the default once G7 is met. With #189 (C28) and #191 (C29), §14.19 shows that G7 is met in s1, s2 and s3. The stall scenarios end in 12–14 s instead of waiting out the 30 s idle timeout.
What
Code
StrategyControlholdsDoublingStrategydirectly.executedrops the Legacy branch and the two speed inputs only Legacy read.&TickSample).Legacy(dynamic_strategy.rs), theGrowthenum andis_doubling;ThroughputSampler::speed, which only Legacy read (per_runner_speedstays);SplitAllTask,SplitGivenTask,get_incomplete_states,find_chunk_to_splitandSplitCandidate.DownloadLoop::ratesis a plainRunnerRates, so the "Legacy samples nothing" branches in the slow and silent restarts, the hedge andplanned_split_sizeare gone.Feature and API (breaking)
unstable-strategyfeature is removed. A crate that enables it no longer builds.GrowthStrategy,TaskOptions::growth_strategyandTaskBuilder::growth_strategyare removed. All three were behind that feature, so the default API is unchanged.BREAKING CHANGEfooter.Bench and docs
docs/task.mddescribe Doubling as the only strategy. That includes the two C29 exceptions: a runner silent for 2 s does not hold growth back, and a runner silent for 4.5 s is restarted.planned_split_size.tests/silent_restart.rsneeds onlytokio.Decisions where T15 was silent
These were made during implementation; the maintainer gave no separate instruction:
Strategytrait andStrategyControl.-D warnings.idm-*.mdanalysis docs untouched and exclude them from T15'srgcheck, because they quote the old code.Tests
Groworsplit(): §14.20 lists each one with its old and new assertion. The property test no longer picks a strategy.range_faults,empty_body,custom_adapter,custom_timer,silent_restartandbolt-load-tests. All pass unchanged.Results
10 runs each, median / p90 in seconds, against §14.19's Doubling.
unmatchedis 0 in every run. The no-stall controls match as well.Review
Reviewed with
/ccg:review, using the codex backend only (a single-model review).Round 1: PASS (96/100). It confirmed three things:
Its two Minors are fixed:
docs/task.mdnow document the C29 silent exceptions.Checks
All on
+nightly-2026-11-06. Clippy allowsunnecessary_lazy_evaluationsuntil #183 merges.cargo fmt --all -- --check.-D warnings. The third used to needunstable-strategyand now builds-p bolt-load --lib --no-default-features --features smol.cargo test --workspace --all-features --lockedandcargo test --workspace --locked.RUSTDOCFLAGS=-Dwarnings cargo doc --no-deps --all-features -p bolt-load: 18 errors, one fewer than its base (aDynamicStrategylink is gone).rg "threashold|DynamicStrategy|unstable-strategy" crates, excluding the twoidm-*.mdanalysis docs: no matches.