GCI94 systematically suggests orElseGet, but could be further optimized#183
Open
MohamedAliSidibe wants to merge 3 commits into
Open
Conversation
jbureau92
requested changes
May 20, 2026
Contributor
jbureau92
left a comment
jbureau92
left a comment
There was a problem hiding this comment.
Thank you for this PR. Few suggestions :
- CHANGELOG should be updated, I suggest adding :
#183 GCI94 - reduce false positives by not flagging orElse with already-defined values (literals, constants, identifiers) - Issue #119 can be automatically closed by adding "Closes #119" in description.
- Nice to have : You should add tests about concatenation, ternary, casts and arrays with
// Noncompliant, to assume these usecases are non compliant.
| reportIssue(memberSelect, MESSAGE_RULE); | ||
| } | ||
| } | ||
| } |
| import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree; | ||
| import org.sonar.plugins.java.api.tree.MethodInvocationTree; | ||
| import org.sonar.plugins.java.api.tree.Tree; | ||
| import org.sonar.plugins.java.api.tree.*; |
Contributor
There was a problem hiding this comment.
Suggested change
| import org.sonar.plugins.java.api.tree.*; | |
| import org.sonar.plugins.java.api.tree.BaseTreeVisitor; | |
| import org.sonar.plugins.java.api.tree.ExpressionTree; | |
| import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree; | |
| import org.sonar.plugins.java.api.tree.MethodInvocationTree; | |
| import org.sonar.plugins.java.api.tree.Tree; |
Author
|
Closes #119 |
Author
|
Mahamadou Ali Sidibe / LesShreks des dépendances moisies / CGI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.