lf_wifi_capacity_test.py: Add support to load the existing test config - #312
Open
tarun-candela wants to merge 2 commits into
Open
lf_wifi_capacity_test.py: Add support to load the existing test config#312tarun-candela wants to merge 2 commits into
tarun-candela wants to merge 2 commits into
Conversation
| port_list.append(eid) | ||
| logger.info(f"Selected Port list: {port_list}") | ||
|
|
||
| idx = 0 |
Collaborator
There was a problem hiding this comment.
if possible keep all var initiations/assinments in the beginning
Collaborator
Author
There was a problem hiding this comment.
Will do it in separate PR for all the initiation/assignments.
haricharan-candela
added
Reviewed
Collaborator
|
Bug risk: Condition |
Collaborator
|
@tarun-candela Also change the commit msg to a proper one, It is saying new functionality and existing. Use old and new or existing and upcoming |
VERIFIED CLI: (New functionality) python3 ./lf_wifi_capacity_test.py --mgr 192.168.204.60 --load_old_cfg --config_name new_config --pull_report VERIFIED CLI: (Existing functionality) python3 ./lf_wifi_capacity_test.py --mgr 192.168.204.60 --upstream 1.1.eth2 --stations 1.1.sta0000 --protocol UDP --duration 60s --pull_report
Verified CLIs: 1. Existing Functionality: python3 ./lf_wifi_capacity_test.py --mgr 192.168.207.78 --upstream 1.1.eth1 --stations 1.1.sta0000 --protocol UDP --duration 60s --pull_report 2. New Functionality: python3 ./lf_wifi_capacity_test.py --mgr 192.168.207.78 --load_old_cfg --config_name customer_scenario --pull_report Signed-off-by: Tarun <tarunkumar.madabathula@candelatech.com>
tarun-candela
added
Ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
VERIFIED CLI: (New functionality)
VERIFIED CLI: (Existing functionality)
Test Logs: