feat: migrate to Swift 6.0 with Sendable/consuming annotations - #9
Merged
Conversation
**Breaking Changes:** - Minimum Swift version: 5.10 → 6.0 - Minimum iOS: 13.0 → 16.0 - Minimum macOS: 10.15 → 13.0 - Minimum watchOS: 6.0 → 9.0 - Minimum tvOS: 13.0 → 16.0 - Minimum macCatalyst: 13.0 → 16.0 **Swift 6 Concurrency:** - Fixed all strict concurrency checking errors - Made MultipartFormData non-Sendable (builder pattern, no isolation transfer needed) - Added SendableBox helper for thread-safe test state - Refactored test log handlers to use actors **Ownership Annotations:** - Added `sending` to HTTPBody parameters in ClientTransport.send() - Added `sending` to HTTPBody parameters in ClientMiddleware.intercept() - Added `sending` to HTTPBody in Client.send() - Added `consuming` to MultipartFormData.encode() and writeEncodedData() - HTTPBody ownership transfer is now explicit and compiler-enforced **Benefits:** - Type-safe ownership semantics prevent accidental body reuse - Self-documenting API with clear resource lifetimes - Compiler optimizations enabled by explicit ownership - All unit tests pass with Swift 6 strict concurrency Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the library to Swift 6.0 with proper Sendable and consuming parameter annotations for better Swift concurrency support.