Repository navigation
feat(subtitle): VobSub and DVB decoders, .idx/.sub and .sup readers - #27
Merged
Merged
Conversation
…ecoder's display sets
…bSub .idx/.sub pair and a PGS .sup
…eeps the sets ahead of an error, passes over junk and gives the page's time-out
… a stop at the start shows nothing, Pending tells a unit waits for its rest
…s along with io.EOF
… time-out and what each decoder tolerates
…a block starts a unit, where Pending dated a unit that dropped the one before by the dropped block
…nd the library example reads each decoder with its own calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitmap subtitle decoders for DVD rips and broadcast captures, and readers for the bitmap subtitles that sit beside a video. Everything is in
mkv/subtitle, additive only.VobSubDecoderandDVBSubDecoder, returning the PGS decoder's display sets (BitmapDisplaySetis the typePGSDisplaySetnames)ParseVobSubIndex+VobSubIndex.ForEachUnitfor a VobSub .idx/.sub pair,ForEachSUPDisplaySetfor a PGS .supPGSDisplaySetgainsDelay,Duration(VobSub start and stop commands) andTimeout(a DVB page's time-out)Continuesto date a unit by its first block, junk and unknown pixel data tolerated, the sets ahead of an error returned with it)Tests: synthetic wire-format tests, fuzz targets for each decoder and reader, and real samples (a DVD's VobSub, a broadcast's DVB subtitles, a .idx/.sub pair, a .sup) whose pictures are compared pixel by pixel with golden renderings.
Local: gate exit 0 on da90230,
make preflight RELEASE=v0.67.0exit 0 on c566d15. gorelease against v0.66.2: compatible changes only, v0.67.0.