Conversation
- Added --log-file <path> CLI flag for file output - Added --log-level <level> CLI flag (error/warn/info/debug/trace) - -v sets debug, -vv sets trace (affects both tracing and Output) - Output now has log level awareness: debug(), trace() methods - Output respects level for filtering (quiet=error only, default=info) - All 17 Output::new() callers updated for log_level parameter - tracing_subscriber upgraded: file output, no targets, configurable level Closes #26
|
🧙 Sourcery is reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
grave0x
added a commit
that referenced
this pull request
Jul 26, 2026
* dwell: fix import_cmd.rs compile error from Output::new signature change PR #29 added a 4th parameter (log_level) to Output::new but import_cmd.rs was written before that change and only passes 3 arguments. * dwell: cargo fmt * dwell: fix clippy warnings in import_cmd.rs --------- Co-authored-by: GitHub Actions Bot <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper logging infrastructure with configurable verbosity, log file output, and structured log levels.
CLI flags
Implementation
Outputstruct enhancementslevelfield (1-5 mapping: error→trace)debug()method — dim blue dot, only at -v/--log-level=debugtrace()method — dim magenta hash, only at -vv/--log-level=traceself.levelbefore printing--quiet(only error level shows)tracing_subscriber upgrade
--log-leveloverride--log-file <path>for file output17 files updated
All
Output::new()callers across all command modules.Closes #26
Summary by Sourcery
Introduce configurable logging levels and optional log file output across the CLI, and route all command output through the new log-level-aware Output abstraction.
New Features:
Enhancements: