Fix "response position" definition; clarify sibling errors on propagation - #1183
Merged
Merged
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
benjie
force-pushed
the
clarify-one-error-per-result-position
branch
from
July 10, 2025 13:11
599b654 to
a3092d9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
benjie
force-pushed
the
clarify-one-error-per-result-position
branch
from
July 10, 2025 16:00
a3092d9 to
fc70008
Compare
benjie
force-pushed
the
clarify-one-error-per-result-position
branch
2 times, most recently
from
July 10, 2025 17:26
e199ebb to
4d6f01b
Compare
Member
Author
|
Plan from today's WG:
|
Contributor
|
graphql/graphql-js#4458 not sure if this is the implementation you want to test, I thought it’s the implementation for: #1184 |
benjie
force-pushed
the
clarify-one-error-per-result-position
branch
from
September 10, 2026 13:50
4d6f01b to
fbd43e8
Compare
benjie
changed the base branch from
main
to
clarify-definition-of-response-position
September 10, 2026 13:52
Member
Author
|
Editorial change for definition of response position extracted to here: |
benjie
added this pull request to stack #1239
September 10, 2026 14:02
martinbonnin
approved these changes
Sep 15, 2026
martinbonnin
left a comment
Contributor
There was a problem hiding this comment.
If a _response position_ resolves to {null} because of an execution error which
has already been added to the {"errors"} list in the _execution result_, the
{"errors"} list must not be further affected. That is, only one error should be
added to the errors list per _response position_.
FWIW, I don't necessarily read this as "the response position at the beginning of the paragraph and at the end must be the same". So the curernt text was ok-ish to me.
Nevertheless, the new text is more explicit so all good 👍
PascalSenn
approved these changes
Sep 17, 2026
Base automatically changed from
clarify-definition-of-response-position
to
main
September 17, 2026 17:48
leebyron
force-pushed
the
clarify-one-error-per-result-position
branch
from
September 17, 2026 17:48
fbd43e8 to
8716c0a
Compare
robrichard
approved these changes
Sep 17, 2026
leebyron
approved these changes
Sep 17, 2026
leebyron
left a comment
Collaborator
There was a problem hiding this comment.
Nice. I like that this cleans up things since the response since the response position might not exist in the response thanks to bubbling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The response position mentioned at the beginning of this paragraph is different to the response position from which the error originated; therefore "only one error should be added to the errors list per response position" is kind of moot. Actually what we mean here is that the response path of the error (i.e. the "path" entry in the error object) should be unique.
This edit clarifies that it's the "path" of the error that matters (and should be unique), not the position that re-raised it.