Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

npm package doesn't have updated GraphiQLOptions for subscription config #746

Description

@ShaneKeney

Not sure where to report issue for npm package in itself so am reporting here. The following is the type file on the latest npm install i.e.

npm install --save express-graphql

via. renderGraphiQL.d.ts

export interface GraphiQLOptions {
    /**
     * An optional GraphQL string to use when no query is provided and no stored
     * query exists from a previous session.  If undefined is provided, GraphiQL
     * will use its own default query.
     */
    defaultQuery?: string;
    /**
     * An optional boolean which enables the header editor when true.
     * Defaults to false.
     */
    headerEditorEnabled?: boolean;
}

Looking at the GitHub repo it seems the additional subscriptionEndpoint? field was added for subscription report. Versioning on npm says 0.12.0 which matches with GitHub versioning but there seems to be a discrepancy and am getting some Typescript errors when trying to use subscriptions because of it.

Seems like npm and GitHub are not in sync.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions