Properly handle integer id#543
Open
Sytten wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
The CI is broken because of unrelated problems |
Member
|
I think we should consider removing integer ID deserialization support. |
Member
|
Let's do that (https://spec.graphql.org/draft/#sec-ID). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542
The integer ID parsing IMO should not have been merged at all, but I spend the day fixing it so at least it is fixed now.
For those that dont care about paying the penalty of this feature, I made a feature that you can disable.