feat(plugin-e2e): fetch e2e-selectors from Grafana at runtime behind a flag#2746
Draft
sunker wants to merge 1 commit into
Draft
feat(plugin-e2e): fetch e2e-selectors from Grafana at runtime behind a flag#2746sunker wants to merge 1 commit into
sunker wants to merge 1 commit into
Conversation
sunker
force-pushed
the
feat/plugin-e2e-runtime-selectors
branch
from
6f0c516 to
1dc7233
Compare
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🧑💻 In development
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an opt-in runtime path to the
selectorsfixture. WithPLUGIN_E2E_RUNTIME_SELECTORS=trueit fetches/public/e2e-selectors.jsfrom the Grafana under test and resolves from that, falling back to the bundled@grafana/e2e-selectors(quiet on 404, warns otherwise). Off by default, so no change for consumers. This keeps plugin e2e tests in sync with the Grafana under test without the nightly npm dist-tag.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: