-
Notifications
You must be signed in to change notification settings - Fork 50
feat(plugin-e2e): add missing components to the components fixture #2621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mckn
wants to merge
14
commits into
main
Choose a base branch
from
mckn/add-missing-components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9c005ae
Plugin E2E: Add Select, MultiSelect, Switch, RadioGroup, UnitPicker, …
2aea99f
Plugin E2E: Fix ColorPicker.getContainer to target parent of swatch
2f21d9f
Plugin E2E: Fix Select and MultiSelect getContainer to target parent
bac195c
Plugin E2E: Add .first() to getContainer to avoid strict-mode failures
46f6de3
Plugin E2E: Fix ColorPicker and RadioGroup container selectors
80f2fb7
chore: re-trigger CI
mckn 67007a6
Plugin E2E: Use data-testid container selectors for Grafana >= 13.1.0
mckn 5d83023
Plugin E2E: Fix Select and MultiSelect getContainer to target parent
mckn 13d013b
Merge origin/main into mckn/add-missing-components
mckn 3efa976
Merge branch 'main' into mckn/add-missing-components
mckn cc93561
Merge branch 'main' into mckn/add-missing-components
mckn 02bf433
ci: bump plugin-actions/e2e-version to v3.0.1 (#2733)
mckn 601e7dc
Merge branch 'main' into mckn/add-missing-components
mckn b5bb2a6
Merge branch 'main' into mckn/add-missing-components
mckn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,17 @@ export class ColorPicker extends ComponentBase { | |
| super(ctx, element); | ||
| } | ||
|
|
||
| static getContainer(ctx: PluginTestCtx, root?: Locator): Locator { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A little bit confusing have two methods with the same name doing different things in the same file |
||
| if (root) { | ||
| return root; | ||
| } | ||
| return ctx.page.locator('[data-testid*="colorswatch"]').locator('xpath=..').first(); | ||
| } | ||
|
|
||
| within(root: Locator): ColorPicker { | ||
| return new ColorPicker(this.ctx, root); | ||
| } | ||
|
|
||
| async selectOption(rgbOrHex: string, options?: SelectOptionsType): Promise<void> { | ||
| await this.element.getByRole('button').click(options); | ||
| await this.getCustomTab().click(options); | ||
|
mckn marked this conversation as resolved.
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.