feat(playwright): migrate report publishing from plugin-actions to GCS#819
Open
mckn wants to merge 4 commits into
Open
feat(playwright): migrate report publishing from plugin-actions to GCS#819mckn wants to merge 4 commits into
mckn wants to merge 4 commits into
Conversation
Ports the playwright-gh-pages actions from grafana/plugin-actions#253 into this repo as standalone versioned actions, replacing the gh-pages branch push with GCS uploads via Workload Identity Federation. Wires the new actions into playwright.yml and adds a publish-reports job that posts report links in PR comments. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
5 tasks
Add an optional `service-account` input to the publish-report action. When set, login-to-gcs switches off direct WIF (use_wif_auth: false) and impersonates the service account via WIF. When empty, behaviour is unchanged (direct WIF). Needed so uploads can target buckets that grant access to a specific SA rather than the direct federated principal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mckn
added a commit
to grafana/plugin-tools
that referenced
this pull request
Jun 25, 2026
Point the E2E report flow at the new actions from grafana/plugin-ci-workflows#819 (upload-report-artifacts + publish-report) and the dev bucket from grafana/deployment_tools#626295. publish-report impersonates the github-e2e-test-artifacts SA so uploads to dev-grafana-e2e-test-artifacts are authorized. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…vent load-time eval error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-gh-pages/upload-report-artifactsanddeploy-report-pagesfromgrafana/plugin-actions#253into this repo asactions/plugins/playwright-reports/upload-report-artifactsandpublish-report, applying Erik's requested renames and dropping the unusedgithub-tokeninput.gh-pagesbranch push with GCS uploads via Workload Identity Federation — removingcontents: writeand restricting report access to Grafana Google Workspace accounts; retention is handled by a 90-day GCS object lifecycle rule.playwright.yml: the per-matrix job now usesupload-report-artifacts(producing a 1-day intermediate artifact +summary.txt), and a new fork-safepublish-reportsjob uploads to GCS and posts a PR comment with report links.bucketandpr-comment-summaryinputs toplaywright.ymlandci.yml(defaulting to a shared internal bucket — provisioning tracked separately indeployment_tools).release-please-config.jsonso they get independent version tags, making them addressable by external consumers (e.g.grafana/plugin-tools).Test plan
upload-playwright-artifacts: trueand confirmgf-playwright-report-*artifacts are produced per matrix entrypublish-reportsjob uploads objects togs://grafana-plugin-ci-playwright-reports/<owner>/<repo>/<YYYYMMDD>/<pr>/...(requires bucket to be provisioned first)storage.cloud.google.com/.../index.htmllinks and the 90-day / Grafana-sign-in notecontents: writepermission is needed and nogh-pagesbranch is created