Skip to content

feat: add plugin-directory support for playwright #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oshirohugo wants to merge 5 commits into from
Closed

feat: add plugin-directory support for playwright #683

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94f211e
feat: add plugin-directory support for playwright
oshirohugo Apr 22, 2026
a31ccb3
point playwright to branch for testing
oshirohugo Apr 24, 2026
ac63b19
fix playwright.yml
oshirohugo Apr 24, 2026
9e72ee3
Change reference back to main
oshirohugo Apr 24, 2026
b3151f1
Merge branch 'main' into use-plugin-directory-on-playwrite
oshirohugo Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,23 @@ jobs:
with:
persist-credentials: false

- name: Read Grafana dependency from plugin.json
id: read-grafana-dep
if: inputs.plugin-directory != '.' && inputs.grafana-dependency == ''
run: |
DEP=$(jq -r '.dependencies.grafanaDependency // empty' "${PLUGIN_DIRECTORY}/src/plugin.json")
echo "grafana-dependency=${DEP}" >> "$GITHUB_OUTPUT"
env:
PLUGIN_DIRECTORY: ${{ inputs.plugin-directory }}

- name: Resolve Grafana E2E versions
id: resolve-versions
uses: grafana/plugin-actions/e2e-version@e2e-version/v1.2.1
with:
skip-grafana-dev-image: ${{ inputs.skip-grafana-dev-image }}
skip-grafana-react-19-preview-image: ${{ inputs.skip-grafana-react-19-preview-image }}
version-resolver-type: ${{ inputs.version-resolver-type }}
grafana-dependency: ${{ inputs.grafana-dependency }}
grafana-dependency: ${{ inputs.grafana-dependency || steps.read-grafana-dep.outputs.grafana-dependency }}

playwright-tests:
needs: resolve-versions
Expand Down Expand Up @@ -179,6 +188,7 @@ jobs:
- name: Install Playwright Browsers
run: ${{ steps.setup.outputs.node-package-manager-exec-local-cmd }} playwright install --with-deps chromium
shell: bash
working-directory: ${{ inputs.plugin-directory }}

- name: Download GitHub artifact
id: download-dist-artifacts
Expand Down
Loading