Skip to content

build: add Makefile and GHA workflow to ensure dist folders are up-to-date#250

Open
xnyo wants to merge 19 commits into
mainfrom
giuseppe/check-dist-drift
Open

build: add Makefile and GHA workflow to ensure dist folders are up-to-date#250
xnyo wants to merge 19 commits into
mainfrom
giuseppe/check-dist-drift

Conversation

@xnyo

@xnyo xnyo commented Jun 18, 2026

Copy link
Copy Markdown
Member

Makes the following changes:

  • Adds a Makefile for generating and checking drifts in the dist files for bundled JS actions (JS actions with dist folder built via @vercel/ncc, currently only e2e-versions).
  • Adds a GHA workflow to ensure that dist folders are up-to-date when there are code changes. Uses the Makefile under the hood

In order for bundled JS actions to be compatible with this system, they must have:

  • a .nvmrc pinning an exact Node version (e.g. 24.11.0)
  • exact, caret-free versions for the inlined runtime deps and @vercel/ncc in package.json (e.g. "@actions/core": "3.0.1", not "^3.0.1")
  • a committed package-lock.json, always installed with 'npm ci'
  • a 'bundle' script in package.json that writes to dist/

These required steps are also checked by the dedicated make check-setup target, and the same message is also printed in CI when an action doesn't have the correct setup

Example failure: https://github.com/grafana/plugin-actions/actions/runs/27817139800/job/82321092585?pr=250

@xnyo xnyo self-assigned this Jun 18, 2026
@xnyo xnyo added enhancement New feature or request github_actions Pull requests that update GitHub Actions code github-actions labels Jun 18, 2026
@grafana-catalog-project-bot grafana-catalog-project-bot Bot moved this from 📬 Triage to 🧑‍💻 In development in Grafana Catalog Team Jun 18, 2026
@xnyo xnyo changed the title ci: ensure dist folders are up-to-date on PRs build: add Makefile and GHA workflow to ensure dist folders are up-to-date Jun 19, 2026
@xnyo xnyo marked this pull request as ready for review June 19, 2026 09:37
@xnyo xnyo requested a review from a team as a code owner June 19, 2026 09:37
@xnyo xnyo requested a review from toddtreece June 19, 2026 09:37
@xnyo xnyo moved this from 🧑‍💻 In development to 🔬 In review in Grafana Catalog Team Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github_actions Pull requests that update GitHub Actions code github-actions

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

1 participant