NO-ISSUE: accept NO-ISSUE in conventional commit scope#7
Merged
Conversation
The repo CLAUDE.md format `<type>(NO-ISSUE):` (e.g. `ci(NO-ISSUE): foo`) was previously rejected because the scope-with-Linear-ID pattern requires digits and the existing NO-ISSUE pattern matched only when NO-ISSUE appeared in the subject. Add a fifth pattern so titles like `ci(NO-ISSUE): foo` are accepted alongside the existing forms. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<type>(NO-ISSUE): subjectis accepted, e.g.ci(NO-ISSUE): foo,feat(NO-ISSUE): bar.[A-Z]+[-\s]\d+), soNO-ISSUEin scope was rejected. The other NO-ISSUE pattern only matches whenNO-ISSUEis in the subject (e.g.ci: NO-ISSUE foo).cloud_optimized_dicom/CLAUDE.md) instruct contributors to use<type>(NO-ISSUE):for ticketless changes, which previously failed this check.Main use case
Dependabot-generated PRs in the COD repo
Accepted formats after this change
PROC-1234: subject(Linear ID prefix)feat(PROC-1234): subject(Linear ID in scope)NO-ISSUE: subject(bare NO-ISSUE)ci: NO-ISSUE subject(NO-ISSUE in subject)ci(NO-ISSUE): subject(new — NO-ISSUE in scope)Test plan
feat(PROC-1234):,NO-ISSUE: ...) still pass.ci(NO-ISSUE): foonow passes.chore: random update) still fails.🤖 Generated with Claude Code