PROC-1513: accept Conventional Commit titles with Linear ID in scope#6
Merged
saicheems merged 1 commit intoApr 21, 2026
Conversation
Allow titles like 'feat(ENG-123): add feature' so repos using release-please can keep Linear issue association without breaking the existing check. Existing 'ENG-123: ...' and 'NO-ISSUE:' formats remain valid.
CalNightingale
changed the title
saicheems
approved these changes
Apr 21, 2026
CalNightingale
deleted the
CalNightingale/allow-conventional-commit-titles
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widen the PR title check so titles like
feat(ENG-123): add featureare accepted in addition to the existingENG-123: ...andNO-ISSUE:formats.Why
Adopting release-please in
cloud_optimized_dicom(see PR #97) requires PR titles to start with a Conventional Commit type prefix (feat:,fix:,chore:, etc.) so the bot can decide the next version. The existing org-level check requires the Linear ID at the very start, which conflicts. Putting the Linear ID inside the conventional-commit scope (feat(ENG-123): ...) satisfies both worlds, but the current regex doesn't recognize it.Change
Two new branches added to the existing if/elif chain:
feat(ENG-123): add featureNO-ISSUEopt-out:chore: NO-ISSUE refactor internalsExisting formats continue to pass — pure superset, zero behavior change for repos not adopting Conventional Commits.
Test plan
ENG-123: existing format→ passes (unchanged)feat(ENG-123): new format→ passes (new)NO-ISSUE: opt-out→ passes (unchanged)chore: NO-ISSUE thing→ passes (new)random title with no marker→ fails