chore: stop passing protected owners and drift reviewers to the reusable workflows - #306
Merged
Merged
Conversation
…ble workflows Both values now come from the deployment environment the reusable workflows already run in -- PROTECTED_OWNERS from plan, DRIFT_REVIEWERS from schedule, both already set. The workflow_call inputs were removed upstream, so a caller that keeps passing them fails with Invalid input once test/rc-cycle picks up the change. Dropping them first is the safe order: the inputs were optional, so the currently referenced revision simply reads an empty value until the branch moves.
Terraform Plan ResultTerraform plan: 0 to import, 0 to add, 0 to change, 0 to destroy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROTECTED_OWNERSandDRIFT_REVIEWERSnow come from the deployment environment the reusable workflows already run in —planandschedulerespectively. Both environment variables are already set on this repository.The
workflow_callinputs were removed in G-Research/github-terraformer#78, so a caller that keeps passing them fails withInvalid inputas soon astest/rc-cyclepicks up that change.Order matters. Dropping the inputs first is the safe direction: they were optional (
default: ""), so the revision currently referenced simply reads an empty value. Movingtest/rc-cyclefirst would breaktf-plananddrift-checkoutright.test/rc-cycleis fast-forwarded onto the merged change immediately after this merges, which closes the short window where the protected-owner rule is not enforced.Repository-level
PROTECTED_OWNERS/DRIFT_REVIEWERSare deleted afterwards — environment variables take precedence over repository variables of the same name, so removing them is what proves the value now comes from the environment.