Round 2: add a plain non-owner member (github_membership create) - #291
Merged
Conversation
Round two, the blocking gap: github_membership create path, never exercised. nkbmilos is a genuine account, not an owner and not in PROTECTED_OWNERS.
Terraform Plan ResultTerraform plan: 0 to import, 1 to add, 0 to change, 0 to destroy. Resources to create: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercises the
github_membershipcreate path, untested in round one because the organisation had only owners.Adds
nkbmilosasrole: member. Expected: plan shows onegithub_membershipto add. On apply GitHub sends an invitation; the account must accept before membership is active.