feat(dtk): post-operation to pin numpy and remove nixl ep for vllm 0.18.1 - #269
Merged
Merged
Conversation
…18.1 - add pack/.post_operation/20260901_dtk_pin_numpy_remove_nixl_ep with matrix rule and overlay Dockerfile porting PR #265 fixes - log the operation in pack/.post_operation/README.md - ignore local .claude/ tooling directory Task 1 of dtk-post-op-pin-numpy-remove-nixl. Signed-off-by: thxCode <thxcode0824@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a post-operation patch for the Hygon DTK 26.04 backend running vLLM 0.18.1. Specifically, it adds a Dockerfile that pins numpy to version 1.26.4 to restore NumPy 1.x ABI compatibility with Torch, and uninstalls CUDA-only NIXL EP packages to prevent execution failures on Hygon DCU systems. It also configures the build matrix rule for this patch, updates the .gitignore to exclude local Claude agent tooling, and documents the new task in the README. There are no review comments, so no additional feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add post-operation
20260901_dtk_pin_numpy_remove_nixl_epto patch the releasedgpustack/runner:dtk26.04-vllm0.18.1image in place, backporting #265 (commit range bc1428f..372b411) to the already-published tag:numpy==1.26.4(uv pip install --no-deps) with a build-time version assertion — the prebuilt DTK Torch is compiled against the NumPy 1.x ABI, and NumPy 2.x breaks distributed init atTensor.numpy().uv pip uninstall nixl nixl-cu12 nixl-cu13 || true) with a build-time assertion thatnixl_ep*modules are no longer discoverable — they make vLLM load an extension requiring NVIDIAlibcuda.so.1, which fails on Hygon DCU.Package layout follows existing post-operation conventions (
matrix.yaml+dtk/Dockerfile), and the operation is logged inpack/.post_operation/README.md.Also ignores the local
.claude/tooling directory.Validation
pre-commit runon all changed files — green.dtk26.04-vllm0.18.1-linux-amd64.Rollout (after merge)
post_operation=20260901_dtk_pin_numpy_remove_nixl_ep,backend=dtk,target=vllm,tag=dtk26.04-vllm0.18.1,dry_run=false,for_release=false→ pushes-devtag.-devtag.for_release=trueto overwrite the released tag, then check off the README entry.