feat(kv-cache): elect Mooncake leaders with Kubernetes Lease by default - #697
Merged
Merged
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 15 selected item(s). |
Collaborator
Author
|
Addressed all three findings in the review summary:
|
thxCode
force-pushed
the
feat/mooncake-default-lease-election
branch
from
September 29, 2026 04:38
262896d to
23f6853
Compare
Collaborator
Author
|
Follow-up on the two findings in the latest review summary:
|
thxCode
force-pushed
the
feat/mooncake-default-lease-election
branch
from
September 29, 2026 04:48
23f6853 to
4a64304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
/kind api-change
/area worker
What this PR does / why we need it:
leader.electionBackendwithKubernetesas the default andNonefor single-replica images without Lease support. RejectNonewhenleader.replicas > 1.leader.highAvailabilitywrapper and expose its only setting asleader.memberAddressing. Drop the obsolete unknown snapshot field checks; retain the snapshot flag safety checks. The API is unreleased, so no migration is required.Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
leader.electionBackend: Nonewhen creating a single-replica backend. The API has not been released yet, so this PR has no migration requirement for existing CR objects.RACE=false make test,make lint,make lint docs,make lint agents-shell,make generate, andgit diff --check.make testfound an independently reproducible race in the unchangedpkg/utils/certs/cachetestTest_k8sCache_TamperedSecretIsLoggedAsKeyValuePairs: its cleanup clears the global klog logger while its informer is still running. This package is outside the PR scope..claude/reports/llm-pd-disaggregation-kvcache-cr-design/v0.9-guide.mdwas updated but is ignored by Git and is outside this PR.Does this PR introduce a user-facing change?