Fix other parts for exit pages - #3086
Merged
Merged
Conversation
thomasiles
marked this pull request as ready for review
September 3, 2026 13:07
lfdebrux
reviewed
Sep 4, 2026
We need to ensure we are reverting exit pages, even when they are not attached to conditions. This commit adds exit pages to the revert draft service.
We need to ensure we are copying exit pages, even when they are not attached to conditions. This commit makes sure exit pages are correctly copied. We also make sure welsh translations are copied correctly.
Change the reports to forms which use the new FormDocument structure. We use a fallback to also show exit pages for legacy form documents.
thomasiles
force-pushed
the
fix-other-parts-for-exit-pages
branch
from
September 4, 2026 08:13
3365284 to
0509da0
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3086.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
lfdebrux
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update exit page related code across the app
Trello card: https://trello.com/c/O0iVW7hX/3213-update-code-not-related-to-routing-to-work-with-new-style-exit-pages
This PR modifies a few different parts of the code which need to be modified because of the changes exit pages.
The main reason the code has to change is because pages can now have exit pages which are not connected to conditions.
The database seed has not been updated. This was in the trello card. The current seed has examples for the new style of exit pages and the existing, condition linked, style. I think this makes sense while both are still possible (the multiple branches work is still behind a feature flag). I've created a new trello card to track tasks to complete when the feature is released and the flag remove.
Things to consider when reviewing