Skip to content

Update Welsh CSV service for multiple exit pages - #3084

Merged
lfdebrux merged 1 commit into
mainfrom
ldeb-multiple-exit-page-translations-csv
Sep 3, 2026
Merged

Update Welsh CSV service for multiple exit pages#3084
lfdebrux merged 1 commit into
mainfrom
ldeb-multiple-exit-page-translations-csv

Conversation

@lfdebrux

@lfdebrux lfdebrux commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/Qe1U2bBO/3181-change-welsh-translation-feature-to-work-with-multiple-exit-pages

When the multiple branches feature is released, the Welsh translation CSV should include the number for each exit page in the row heading, so that exit pages can be uniquely identified for a form when there's a page with more than one exit page.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

When the multiple branches feature is released, the Welsh translation
CSV should include the number for each exit page in the row heading, so
that exit pages can be uniquely identified for a form when there's a
page with more than one exit page.
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3084.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@thomasiles thomasiles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🏅

@lfdebrux
lfdebrux added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit 2ca1847 Sep 3, 2026
4 checks passed
@lfdebrux
lfdebrux deleted the ldeb-multiple-exit-page-translations-csv branch September 3, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants