Skip to content

WIP shows routes with exit pages - #3071

Draft
SamJamCul wants to merge 1 commit into
mainfrom
view-live-form-multiple-exit-pages
Draft

WIP shows routes with exit pages#3071
SamJamCul wants to merge 1 commit into
mainfrom
view-live-form-multiple-exit-pages

Conversation

@SamJamCul

Copy link
Copy Markdown
Contributor

This currently shows routes on the live pages view in all cases, for goto pages, skip to end and exit pages.

There's still a chunk left to do, as the exit page contents needs to be displayed at the end of each page section, and the Welsh translations variant of the page list view needs this behaviour as well.

I started refactoring the logic that constructs the answer_value_groups but didn't quite get far enough. At the moment, that method is very clunky, and should probably be broken up into multiple methods.

What problem does this pull request solve?

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

This currently shows routes on the live pages view in all cases, for
goto pages, skip to end and exit pages.

There's still a chunk left to do, as the exit page contents needs to be
displayed at the end of each page section, and the Welsh translations
variant of the page list view needs this behaviour as well.

I started refactoring the logic that constructs the answer_value_groups
but didn't quite get far enough. At the moment, that method is very
clunky, and should probably be broken up into multiple methods.
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3071.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant