WIP shows routes with exit pages - #3071
Draft
SamJamCul wants to merge 1 commit into
Draft
Conversation
This currently shows routes on the live pages view in all cases, for goto pages, skip to end and exit pages. There's still a chunk left to do, as the exit page contents needs to be displayed at the end of each page section, and the Welsh translations variant of the page list view needs this behaviour as well. I started refactoring the logic that constructs the answer_value_groups but didn't quite get far enough. At the moment, that method is very clunky, and should probably be broken up into multiple methods.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3071.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently shows routes on the live pages view in all cases, for goto pages, skip to end and exit pages.
There's still a chunk left to do, as the exit page contents needs to be displayed at the end of each page section, and the Welsh translations variant of the page list view needs this behaviour as well.
I started refactoring the logic that constructs the answer_value_groups but didn't quite get far enough. At the moment, that method is very clunky, and should probably be broken up into multiple methods.
What problem does this pull request solve?
Trello card:
Things to consider when reviewing