Fix markdown length validation for exit pages - #3067
Merged
Conversation
When the char count for the markdown field is too long, the error cannot be displayed because the translations assumed the count field was available. As the error is checked in the markdown gem and added to the model in the our validator, it doesn't set the count field. I looked at different ways of making the count available. I don't think it's worth making wider code changes though. Instead, I've hardcoded the 5000 character limit in the translations.
thomasiles
marked this pull request as ready for review
August 26, 2026 14:53
DavidBiddle
reviewed
Aug 26, 2026
Correct char count Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
DavidBiddle
reviewed
Sep 2, 2026
Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3067.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
DavidBiddle
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the char count for the markdown field is too long, the error cannot be displayed because the translations assumed the count field was available.
As the error is checked in the markdown gem and added to the model in the our validator, it doesn't set the count field.
I looked at different ways of making the count available. I don't think it's worth making wider code changes though. Instead, I've hardcoded the 5000 character limit in the translations.
What problem does this pull request solve?
Trello card:
Things to consider when reviewing