Conversation
Document option 1 from #2021 — the "Main CI Required" ruleset runs status checks in strict mode so a branch must be up to date with `main` before it can merge, re-running the checks against the latest trunk. This closes the #2017 class of break, where two individually-green PRs (#1875 + #1970) broke `main` in combination. Notes the post-merge push backstop (#2030) alongside. The ruleset toggle itself (strict_required_status_checks_policy) is a repo setting that requires admin and must be flipped in GitHub settings; this PR documents the intended policy in CLAUDE.md and the trunk-based playbook. Refs #2021 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Amplify PR previews
Commit:
|
Contributor
Author
|
The strict-mode ruleset toggle documented here requires admin and is tracked separately in #2040 (assigned to @LaronGovT and @RootUserChris). Once that toggle is flipped, the policy described in this PR is fully enforced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents option 1 from #2021 — the primary recommended fix — in CLAUDE.md and the trunk-based playbook (docs/trunk-based-development.md): the Main CI Required ruleset runs status checks in strict mode, so a branch must be up to date with
mainbefore it can merge, re-running the required checks against the latest trunk.Why (addresses #2021)
mainwent red on the requiredValidate Recipescheck for every open PR (incident #2017), yet no single PR "failed" — the break emerged from the combination of two individually-green PRs:main).Strict status checks force that re-run at merge time, catching this class of break. #2030 already added the post-merge
pushrun onmain(option 2) as the fast-visibility backstop; this PR documents the strict-mode policy that complements it.The ruleset toggle itself is a repo setting, not code, and requires admin permission (the PR author has
maintainonly). This PR documents the intended policy — a repo admin must flip it for the docs to be true:Until that toggle is flipped, #2021 is not fully resolved — hence Refs, not Closes.
Scope
Refs #2021
🤖 Generated with Claude Code